https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Hi Nick, having a first look here: 1) FAIL Koha/KeyboardShortcuts.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for 'object_class' 2) No tests? 3) Translation issues a) Ctrl is not labelled Ctrl on German keyboards, it's Strg - so people might not understand. Currently I can fix this in translation, but with the new system that will not work. We could add another column for a 'spelled out' mapping or we could add some replacing in the template that can be translated. Not sure here. (Not quite blocker... but meh) b) The new file is missing from the translated installers. (blocker) I'd like to suggest a different approach here. As you can't invent your own keyboard shortcuts, I'd deal with this like with the permissions. Have one SQL file with the mandatory values on top level (not in language directories) and deal with the description translation in the templates. 4) I am wondering if tools is the right place for this. I think I would put it with Sound alerts and column configuration in Administration. 5) If we leave it in tools: It's missing from tools sidebar and start page. If we move to admin, we'll also need sidebar and start page. As the navigation of tools shows on the tool page, I think that makes it currently a bit confusing. 6) Permissions: currently it doesn't require any permission: flagsrequired => {}, Do we want to leave it like this? As the keyboard shortcuts are global and not per user I can imagine libraries would not want anyone be able to reconfigure them. 7) "If combing multiple keys " - interesting idea :) 8) The button is a bit close to the table, could use a little template clean-up. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/