https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fisc...@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- I think one of the issues here is the library charging fines on days the library is closed (finesCalendar), but at the same time offering the book drop with on those days. It seems contradictory to me to waive fines from days closed when returned on a day the library is closed but charge them in the first place. As such it's probably a rare case? I also see an issue with this line: if ( $return_date_specified || ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue ) ) We have turned off CalculateFinesOnReturn for quite a few libraries and that would cause us trouble. We don't want to recalculate ever. my $fines = Koha::Account::Lines->search( { issue_id => $issue->issue_id }, { order_by => { '-asc' => 'date' } } ); Are we also sure that this will not cause other problems? I don't think we should be touching F fines. What happens if there are multiple F and 1 or 0 FU fines on the same issue? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/