https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Nick Clemens <n...@bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |n...@bywatersolutions.com
           Keywords|                            |additional_work_needed

--- Comment #16 from Nick Clemens <n...@bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #15)

This one can be done in a follow-up please Kyle? Pushing for now

> Passing QA but frowning:
> 
> +    my @itemtypes = sort map { uc $_->[0] } @{
> C4::Context->dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) };
> 
> +my @available_itemtypes = map { uc $_->[0] } @{
> $dbh->selectall_arrayref(q|SELECT itemtype FROM itemtypes|) };
> 
> Old school SQL..
> 

This seems okay to me, we should make a rule somewhere if we like this or not

> The earlier mention of --list-itemtypes is no blocker for me.
> Leaving final decision to RM ;)

Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to