https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292
Kyle M Hall <k...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #10 from Kyle M Hall <k...@bywatersolutions.com> ---
(In reply to Marcel de Rooy from comment #9)
> + $resp .= add_field( FID_FEE_AMT, $status->fee_amount, $server );
> + $resp .= maybe_add( FID_CURRENCY, $status->sip_currency,
> $server );
> + $resp .= maybe_add( FID_FEE_TYPE, $status->sip_fee_type,
> $server );
> + $resp .= maybe_add( FID_TRANSACTION_ID,
> $status->transaction_id, $server );
>
> I have some doubts here. Will this work if people add such fields to the
> hidden list? Or should these be added no matter what? So moved to add_field?
> Maybe there are more ?
I see no reason to override a librarian's ability to scrub any particular SIP
field. That just makes the feature inconsistent, and for all we know maybe
there *will* be a scenario where a library needs to not send those fields to a
particular service.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
