https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23272
--- Comment #13 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #12) > Just added a followup here to fix the failing tests.. as the commit says > however I took the quick option of adding a ternary.. perhaps a longer > discussion is in order to settle on a returns guideline for koha object > methods. To me, if an object is expected as the return we should always > return an object (even if it's an empty/full object) rather than ever > returning an implicit 'undef'. That would prevent the need for ternaries > throughout the codebase checking the return value before chaining methods. > > Thoughts. Good catch. Changing the returns of Koha objects is a nice exercise now ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
