https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #47 from David Gustafsson <glask...@gmail.com> --- (In reply to Nick Clemens from comment #42) > Rebased and tested, this works excellently, I would love to move this > forward, but I see a few issues in the patches: > 1 - You removed QueryWeightedFields, but Zebra uses this, I obsoleted that > patch > 2 - There are changes to the authority searches here, things are improved, > but a bit too strict, they don't relate to this bug, can you move those to a > new report? > 3 - Schema changes are mixed into first patch, they should be their own so > RM can generate separately > 4 - I did a minor rebase on top of 22258 and added a followup to allow > searchig the entire record if using marc array > > Let me know if this makes sense or if I went too far anywhere Thanks for the feedback! Rebased aagainst master since did not apply again. 1) Ok, I obviously missed that used by Zebra, thanks! 2) I gave this a lot of thought, but on the other hand not sure got it right. It would be possible to break out some changes introduced into separate issues, but they would all depend on each other and would be harder to maintain. So it's bundled together for practical reasons and time constraints. I might have time later on to split things up, but unfortunately not at the moment. 3) Forgot to fix this, but will do that. 4) Great, thanks :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
