https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fisc...@bsz-bw.de
--- Comment #3 from Katrin Fischer <katrin.fisc...@bsz-bw.de> ---
Hi Arthur,
just some feedback on formal stuff:
1) Please always start your commit messages with Bug: xxxx (no extra space
before the :). I usually fix those, but it gets boring fast :)
2) There is a lot of complaints about whitespace. Please make sure your editor
is set to not use tabs but 4 spaces instead.
FAIL C4/ILSDI/Services.pm
OK critic
FAIL forbidden patterns
forbidden pattern: tab char (line 644)
forbidden pattern: tab char (line 646)
forbidden pattern: tab char (line 647)
forbidden pattern: tab char (line 651)
forbidden pattern: tab char (line 653)
forbidden pattern: tab char (line 654)
OK git manipulation
OK pod
OK pod coverage
OK spelling
OK valid
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
OK filters
FAIL forbidden patterns
forbidden pattern: tab char (line 69)
forbidden pattern: tab char (line 692)
forbidden pattern: tab char (line 693)
forbidden pattern: tab char (line 697)
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL opac/ilsdi.pl
OK critic
FAIL forbidden patterns
forbidden pattern: tab char (line 94)
forbidden pattern: tab char (line 112)
OK git manipulation
OK pod
OK spelling
OK valid
It's also very good to get into the havig of running the QA test tools, so
those can be caught and fixed early!
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
