https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|ILS-DI doesn't implement |ILS-DI doesn't implement |needed_before_date and |needed_before_date and |pickup_expiry_date |pickup_expiry_date |parameters. |parameters CC| |katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- 1) Same formal issues than on bug 23015: - commit message - failing qa tools for tabs vs. spaces FAIL C4/ILSDI/Services.pm OK critic FAIL forbidden patterns forbidden pattern: tab char (line 730) forbidden pattern: tab char (line 735) forbidden pattern: tab char (line 816) forbidden pattern: tab char (line 821) OK git manipulation OK pod OK pod coverage OK spelling OK valid 2) Unit tests for change to Service.pm 3) I am not sure about the patch 'content'. needed_before_date = Visible on the Koha holds form as 'Hold not needed after'. Stored in the database in reserves.expirationdate. Correct? pickup_expiry_date = This one confuses me. The expiration date for pick-up is usually calculated by Koha using different configuration parameters and not something that the user can 'pick' at the time of placing a hold. But what makes it worse: Both go in the same column in the database atm (yes, bad). When a hold is set to waiting, the pick-up date is calculated and rebases the patron entered date in reserves.expirationdate. So... I think this cannot work? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/