http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
--- Comment #97 from Paul Poulain <paul.poul...@biblibre.com> --- (In reply to comment #96) > I discovered that in a perl file I needed to define routines for these > queries and comments, and I did not think that it was easier. With just a > use Context, a db handle and the "old style" sql statements things seemed > easier.. The idea behind this feature is not to ease developers, but future administration of the database. Suppose you've handled 3.05.00.017 upgrade. It does a different SQL request depending on your MARC flavour. With this patch, you will know, *6 months later*, which SQL requests you *had* executed. Whatever your parameters are *today* The .pl can do complex things to build queries, but what we're doing is execute SQL, exactly like when you have .sql file. I agree it's a little bit more for developers (but only a little bit more), but can be really helpfull for dbadmin, so it's worth the price. About other points: * Ascending order for table on admin/updatedatabase => it was not a mistake. When you'll upgrade in production, you'll be happy to see what's new & need to be applied first. With the patch as it was, one would see that he has to apply 3 patches. * Important typo $koha39=~ should be assignment. Updated version number in install and Auth due to removing older sql files. => agreed it was a mistake * Typo _get_queries: removed the call after all; it is easier to leave SQL in perl files outside the update tables. Added some checks for emptiness. => see below, I think it's should be kept * Corrected execution of perl dbrevs (filepath). => I don't understand (note about the updated patch = it's easier to have follow-up in a case like this one, it makes much more clear what has been changed ! The RM or QAer can squash all patches when things are OK, just before pushing) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/