https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
--- Comment #110 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Hi Maryse, small failure in the QA script: 1) QA script FAIL installer/data/mysql/atomicupdate/bug_12446-EnableAdultGarantee.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/kohastructure.sql OK boolean_vs_tinyint OK charset_collate OK git manipulation FAIL tinyint_has_boolean_flag The new column categories.canbeguarantee is using TINYINT(1) as type but is not defined as boolean in the schema file (Koha/Schema/Result/Category.pm), see the SQL12 coding guideline The first could be fixed by squashing the patches in question, but should only be done if they got the same author/tester lines. 2) Quick code review Looks good so far, will continue testing with the follow-ups (switch back to signed-off) Note: I feel that GuarantorFields and "Shows guarantees' fines in the guarantor's page" should have been separate features/bugs - they add even more code to check and work through and make this this harder to test and harder to advertise/document. The bug title/description is actually not what this patch does, but is what will show up in release notes. - Too late now I guess, but I think it's part of the reason this has not been moving as fast as hoped for. :( -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/