https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
--- Comment #36 from AgustÃn Moyano <agustinmoy...@theke.io> --- (In reply to Jonathan Druart from comment #35) > Thanks Agustin, it's a bit more clear. > > More questions then :) > Is there a plan to have a UI view of club_holds_to_patron_holds? I don't remember exactly what we planned for this table, but I do remember that we created them for traceability. But it's not a bad idea to have a "club holds history" in a near future. > If not, what's the point of it? Could not we replace it with entries in > action_logs? I didn't know action_logs table existed.. I should study it. > The enum on error_code is weird, and will lead to issues: everytime a new > status is returned by the subroutine we will need to adjust the enum. It > seems that it should be a simple varchar. You're right.. It's a bad design > By the way what is the difference between error_code and error_message? > (Documentation is missing in kohastructure.sql :) error_code holds the result of C4::Reserves::CanItemBeReserved or C4::Reserves::CanBookBeReserved depending if you are trying to hold on a item or a biblio. error_message says "Could not create hold for Patron(".$patron_id.")" if C4::Reserves::AddReserve fails.. maybe we can have only one column of error messages. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/