https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461
--- Comment #46 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #45) > (In reply to Jonathan Druart from comment #44) > > What do others think? Could we get your opinions? > > I think having option to get email notices as well as having the staff > interface is useful - I don't think we need to pick only one - but once > there is a GUI the notices should be optional The problem with having the GUI after is that we do not deal with some of the already created fields. See comment 42: "the status will never be updated, what will happen when we will have the UI?" > >Bug 4461: Use KohaAdminEmailAddress pref as 'from' > I don't understand that followup - 'from_address' is just picked form the > message in C4/Letters - it is 'to_address' that usually gets filled at send > - to be to the borrowernumber > > In this case I think we could set it as: > $patron->notice_email_address || $koha_admin; I do not think so, as said in the commit message "I do not think it's a good idea, we should not send an email with "from" if not really sent by the user." I think it's bad practice to do that, I may be wrong however. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/