https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
--- Comment #80 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Lari, I have rebased the patches. Wondering about find_with_message_name Koha::Patron::Message::Preferences->find_with_message_name({ borrowernumber => 123, message_name => 'Hold_Filled', }); Should not we prefer something like: $patron->messaging_preferences->filter_by_message_name('Hold_Filled'); or even: $patron->messaging_preferences->search({ message_name => 'Hold_Filled' }); ie why is it a class method? Same for the setter, there is only 1 set_default_messaging_preferences, why cannot we add set messaging preferences directly from $patron? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/