https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
Nick Clemens <n...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #127 from Nick Clemens <n...@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #126) > Nick, would you mind continuing here as you did the last review? C4/AuthoritiesMarc.pm: sub AddAuthorityFromHeading - added but never used - can remove test as well C4/Biblio.pm: sub LinkBibsHeadingsToAuthorities please add verbose tests to t/db_dependent/Biblio.t C4/Linker.pm - remove POD changes (no changes to code here) authorities/authorities.pl - I do not think we need the line below + use C4::Heading; cataloguing/automatic_linker.pl: - should be in svc I think - This dupicats the sub "BiblioAutoLink" - instead that sub should be updated to pass through the 'verbose' switch and pass back results and this script can simply call that sub koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt: please use a CSS class rather than hardcoded color value koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: please use a CSS class rather than hardcoded color values Other improvement, could be on new bug: 1 - This doesn't work with the advanced cataloging editor - code should be made flexible enough that can be done 2 - If links are changed they become green - if button clicked again they are not green - may not be obvious that I still need to save changes - i think a second run should preserve what was changed since the record was opened/created. 3 - The notice about links should show the headings that were linked/not-linked otherwise it can be confusing which individual 650 had an issue - colors are nice but we should not rely only on colors for accessibility -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/