https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166
--- Comment #54 from Joonas Kylmälä <joonas.kylm...@helsinki.fi> --- (In reply to Katrin Fischer from comment #39) > we usually don't remove the sign-off lines - that's one reason we prefer > follow-ups - because it allows to see the changes, but also because that > means you don't change what has been signed off by someone. sorry for the mess! I was working on signing-off the patches the same time as Nick and hadn't noticed he had submitted his signed-off-by lines just some minutes earlier so when I ran git-bz attach with my patches it overrode his signed-off-by lines with mine. And then Nick had noticed the QA tool failure after his sign-off and put the bug to FQA state so I thought it would be best to wait for him to sign-off again, which also prompted for me to remove my own SO lines. Anyhow, Nick signed-off this now and I added my QA sign-off so ready for RM to merge :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
