https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357
Joonas Kylmälä <joonas.kylm...@helsinki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #102 from Joonas Kylmälä <joonas.kylm...@helsinki.fi> ---
(In reply to David Cook from comment #101)
> Created attachment 109133 [details] [review]
> Bug 16357: Only use Log4perl middleware if appenders defined
>
> This patch checks that the loggers used by the middleware
> actually have appenders defined.
>
> Without this patch, if the loggers don't have appenders
> defined in the log4perl file, the logs will just be lost.
Thanks for the patch, I think this is also a reasonable approach given the
issue with get_logger() and it works as expected when I tested it. Jonathan
mentioned something about showing missing Log4perl configuration in about.pl
page, I see that as a follow-up bug report given the approach taken here should
at least prevent the case where sysadmin has missed out on the need of these
required config lines entirely. To truly prevent any issues we probably would
have to hard code the log4perl.conf which is not good idea in my opinion.
David, in the patch I have this tiny nitpick: it misses the Log::Log4perl
module import line, which might cause issues later if Koha::Logger in the
future doesn't do it. Can you resubmit the patch?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
