https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #263 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #260) > (In reply to Jonathan Druart from comment #259) > > Patches have been rebased against master. > > Looking here: > 1 - Foreign key constraints on items table 'ON DELETE' updates are affected > here - for instance a hold is not deleted if an item is deleted (can be done > from additem.pl) Indeed. I listed itemnumber FK here: (I am adding FIX when this patchset will actually fix the problem for this column ie. we won't lose anymore the FK): * branchtransfers.itemnumber => must be deleted when marked as deleted * issues.itemnumber => there is a restrict at DB level and a FIXME in the code, I am opening a new bug report * items_last_borrower => FIX * creator_batches => ? TODO? * reserves => follow-up is coming * old_reserves => no change expected * serialitems => ? TODO? * tmp_holdsqueue => follow-up is coming * accountlines => I need help on this one, hard to tell for me * course_items => follow-up is coming * hold_fill_targets => ? TODO? * article_requests => FIX? (as there is a on delete set null) * club_holds => I did not manage to have clubs.item_id different than NULL. How do I do that? (see bug 19618 comment 38) * stockrotationitems => I am not familiar with stock rotation, but I am expecting change in behaviour here - TODO? * return_claims => FIX (?) biblionumber FK: * biblioitems => OK * items => It's handled in an ugly way in DelBiblio. Must be fixed later with a move to Koha::Biblio * reserves => Done in DelBiblio * old_reserves => no change expected here * reviews => FIX * subscription => Done in DelBiblio (Note that maybe we could remove that to have a "undo" ft) * serial => will be deleted on cascade when the subscription will be deleted * subscriptionhistory => same as before * tags_all, tags_index => I think the tags must be deleted when the biblio is marked as deleted TODO? * virtualshelfcontents => TODO! We will deleted to restore the existing behaviour * suggestions => TODO, restoring existing behaviour * aqorders => FIX (?) see also bug 10758 * biblioimages => FIX (?) this will take disk space, but can be reused for "undo". Can be done to restore the existing behaviour if needed * ratings => FIX (?) same as biblioimages for "undo" * hold_fill_targets => TODO? * article_requests => TODO? * biblio_metadata => OK * club_holds => TODO I have opened a pad at https://annuel2.framapad.org/p/koha_bug_20271_fk-9im9?lang=en Please discuss there and I will copy it back here once we are done. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
