http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211
--- Comment #7 from Jared Camins-Esakov <jcam...@cpbibliography.com> --- (In reply to comment #6) > QA Comments: > > Looks good to me. > Code clean, UT++ > > Just one thing: maybe it would be better to pass a hashref to parseQuery > instead of 7 arguments. But it is possible to have some disagreements about > that. The reasoning behind using the 7 arguments is that parseQuery is still just a shim, so we want it to look as much like buildQuery as possible. When parseQuery replaces buildQuery, the API will also be changed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/