http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726
--- Comment #9 from Jared Camins-Esakov <jcam...@cpbibliography.com> --- (In reply to comment #8) > QA comments: > > * 3 perlcritics errors on Koha/SuggestionEngine/Base.pm: > Expression form of "eval" at line 137, column 12. See page 161 of PBP. > (Severity: 5) > Expression form of "eval" at line 151, column 12. See page 161 of PBP. > (Severity: 5) > Expression form of "eval" at line 165, column 12. See page 161 of PBP. > (Severity: 5) > But I don't know how to fix them! I'll see if I can figure something out. > * The 2 sysprefs don't appear in a yaml file. I understand why (there is a > specific config page) but they appear in the "Local Use" tab :-/ > It could be considered as an issue. I think this is a feature, because that way it is possible to work around not having javascript. My warning makes it very clear that setting those sysprefs directly is a bad idea, though. > * It would be great to provide 2 patchs. 1 for the feature and 1 for the > jQuery changes. Like that if a problem appears on it, it will be easy to > revert the commit. I will break the existing patch into two, and do a follow-up for the overflow. > I don't find anything else :) > It works great ! > > I Failed QA for the overflow issue (see previous comment). After that I will > be happy to mark it as passed qa. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/