https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26225
David Nind <da...@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108394|0 |1 is obsolete| | --- Comment #2 from David Nind <da...@davidnind.com> --- Created attachment 110817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110817&action=edit Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch, go to Administration -> Audio alerts. - Click the "Delete selected alerts" button without checking any checkboxes. You should see an error: "Check the box next to the alert you want to delete." - Check the checkbox for an existing sound and click "Delete selected alerts." You should get a confirmation message, "Are you sure you want to delete the selected audio alerts?" - Click "New alert." - Without filling any details, click the "Play sound" button. You should see an error message, "Please select or enter a sound." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.: msgid "Are you sure you want to delete the selected audio alerts?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <da...@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/