https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Hi Andrew, starting with some QA work here. Tbh I've never heard of this specific functionality in an ILS before and am a bit stumped on the use case. Can you explain a bit on how this is used in libraries? 1) QA script fails FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Use of DateTime->now should certainly be replaced with dt_from_string (bug 24840) (line 2933) FAIL t/db_dependent/Circulation/issue.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Can't locate Koha/IssuingRules.pm in @INC (you may need to install the Koha::IssuingRules module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/kohadev/plugins) 2) Database updates There is lots of them :) a) The one thing that gives me a bit of a headache is the change to the notices for existing installations. I think we should leave that one out as we cannot safely assume what people have 'done' to this notice - they will have translated it, might have decided to not inform patrons of the reasons at all, changed the structure etc. I feel we should not interfere here. b) You have a mismatch between kohastructure.sql and the updates for issues/old_issues: AFTER renewals vs. after auto_renew 3) Strings in Javascript This is an old patch, I am aware, but not sure if you have seen yet: We are moving the strings back into the js as they can be finally translated within the file now. See bug 21156 for examples. I am not going to block this, but it would be nice if the patches could be changed to use the new mechanism right away. 4) Terminology We just did a major clean-up on the system preferences, that's why I am a bit nit-picky there. Every change later requires translators to do the work again too - so it might be forgiven: + - renewals to be recorded as "unseen" by the library, and count against the borrowers unseen renewals limit Can you please make the borrowers patrons and add a .? 5) Web based self check Renewals are also possible with the web based self check - so I feel some changes will be needed there as well! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/