https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663
--- Comment #24 from Nick Clemens <n...@bywatersolutions.com> --- Created attachment 111309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111309&action=edit Bug 25663: [20.05.x] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules Bug 25663: Add unit tests This patch adds unit tests for a new get_lostretun_policy method which is getting added to Koha::CirculationRules. Test plan: 1/ Read the additions to t/db_dependent/CirculationRules.t code and compare to the t/db_dependent/RefundLostItemFeeRule.t. 2/ Run the test after applying the patch that adds the new method 3/ If the tests all pass, signoff Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> Bug 25663: Add get_lostreturn_policy method to CirculationRules This patch adds a new get_lostreturn_policy method to Koha::CirculationRules which returns a boolean to the caller which denotes whether a refund should be applied or not on the return of a lost item. Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> Bug 25663: Remove Koha::RefundLostItemFeeRule and uses This patch replaces all calls to RefundLostItemFeeRules with Koha::CirculationRules->get_lostreturn_policy and removes the module it makes redundant. Test plan 1/ Confirm that there are no longer any uses of RefundLostItemFeeRules in the codebase 2/ Confirm circulation tests still all pass 3/ Confirm you can still set and unset the lost return rules 4/ Signoff Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=25633 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/