https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
--- Comment #38 from Andrew Isherwood <andrew.isherw...@ptfs-europe.com> --- (In reply to Nick Clemens from comment #31) Hi Nick Thanks for the feedback > [..] I wonder why the scope > of information is limited for each object > if I modify a field that isn't logged a line is > added to the log, but no info on what was changed is recorded, e.g.: > - update order notes, change statistics > - add user to budget, lock budget, make budget active, change name > - change fund name, change statistics > Is the size concern reason enough to avoid logging the object unblessed? The development was funded by a few customers who had very specific requirements for what they wanted logging, the patches address these requirements. As you know, acquisitions is a vast area and even relatively simple objects (for example, a fund) have many properties. We **could** just do what has been done in other areas and just dump the entire object into the log, but another key requirement for our customers was that they actually had to be able to create meaningful reports on the logged data. I have therefore been discriminating in what data is logged and how it is logged to enable them to do this. I hope that the approach I've taken will make it relatively trivial for others to extend this logging as and what required, but I felt it was more prudent to take a step by step approach rather than just logging everything. > Adding a new basket records two lines: > Create an acquisitions basket > Modify an acquisitions basket header This is actually reflecting what Koha does, it creates the basket then modifies the header (see: https://github.com/PTFS-Europe/koha/blob/master/C4/Acquisition.pm#L190-L207) however, I did notice that the logging of the basket creation was happening after the header had been modified, so I've corrected that. > Cancelling receipt of an order is not logged This was not on our customers list of requirements, hence has not been added. > Creating a budget is logged as modification I can't replicate this, budget creation isn't logged at all, for the reason given above. > Budget/funds record a change of amount because of decimal difference: > "budget_amount_new":"6.00" > "budget_amount_old":"6.000000" I'm just logging what Koha is using, it feels like it's asking for trouble to add or remove precision for the purpose of logging, particularly when those values will be used for reporting. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/