https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #109 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- 1. POD for Koha::Hold->desk is wrong 2. If not desk set, biblio hold list (reserves/request.pl) explodes with: Can't call method "desk_name" on an undefined value at /kohadevbox/koha/reserve/request.pl line 661 3. The desk's name is not correctly escaped in the patron's hold list (circ/circulation.pl, "Holds" tab) Try to use the following string as a desk name: <script>alert("❤");</script> Search for "escapeHtml" in the same js file for the solution. 4. I am not sure about the desk_id parameter we passed to Koha::Hold->set_waiting. We could also set it from ModReserveAffect, what's the benefit of this approach? Failing QA for 1, 2, 3. 4 is for discussion. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/