https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986
--- Comment #41 from Séverine Queune <severine.que...@bulac.fr> --- (In reply to Nick Clemens from comment #40) > (In reply to Séverine Queune from comment #36) > > This patch works fine ! > > But I won't sign it because of 2 points : > > - I can't test the sms part, I don't know how it works and how to use the > > feature > > - I've got a question about the content of the message : when there several > > holds, only the informations about the oldest reserve (for what I saw) are > > displayed. Fields coming from the items or biblio tables can't be used. I > > know it's happening for some other notices so don't Failed the patch because > > of this point, but I regret I couldn't use the <<count>> or > > <<items.content>> datas as it is recommended for some other notices, I think > > it could be useful for patron to have some details about the waiting holds. > > - sms part works exactly like email up to the sending of the message, so > testing is the same, just need to confirm it makes it into the queue > > - the notice supports template toolkit, so you can get other holds > information like: > Dear [% borrower.firstname %] [% borrower.surname %], > > Your hold for [% hold.biblio.title %] is waiting since [% hold.waitingdate %] > > [% IF borrower.holds.count > 0 %] > You also have other holds: > [% FOREACH hold IN borrower.holds %] > [% hold.biblio.title %] : [% hold.found %] > [% END %] > [% END %] > > That could be cleaned up and made fancier, but just to give an idea Thanks Nick ! I completely forgot we could use template toolkit #ashamed... Do you need a second sign off for that one ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/