http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804
Paul Poulain <paul.poul...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
CC| |paul.poul...@biblibre.com
--- Comment #4 from Paul Poulain <paul.poul...@biblibre.com> ---
QA comment:
OK, i'm a little bit excessive, but that's what QA is made for ;-)
Unless i'm mistaking, there is a useless ()
+ if ((($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/) &&
$opac_limit_override) || ($in->{'query'}->param('limit') &&
$in->{'query'}->param('limit') =~ /branch:(\w+)/)){
can be written
+ if (($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/ &&
$opac_limit_override) || ($in->{'query'}->param('limit') &&
$in->{'query'}->param('limit') =~ /branch:(\w+)/)){
=> if ((A && B && C) || (D && E))
am I right ? If yes, please fix & resubmit
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
