https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058
--- Comment #19 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> ---
From CanBookBeRenewed:
next unless IsAvailableForItemLevelRequest($item, $patron);
next unless CanItemBeReserved($borrowernumber,$itemnumber);
Why didnt we add a parameter to CanItemBeReserved if we need to specifically
check for item level request?
At least some checks are done twice.
Same in opac-reserve.pl and request.pl
$policy_holdallowed &&=
IsAvailableForItemLevelRequest($item, $patron) &&
CanItemBeReserved( $borrowernumber, $itemNum )->{status} eq 'OK';
&& $can_item_be_reserved eq 'OK'
&& IsAvailableForItemLevelRequest($item_object, $patron,
undef, $items_any_available)
So, in conclusion: The ItemLevelRequest is often used together with a
CanItemBeReserved.
We are changing here ItemsAnyAvailableAndNotRestricted. Which is called by
ItemLevelRequest. And which - how funny - even calls (sometimes)
CanItemBeReserved.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
