https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28058
Owen Leonard <oleon...@myacpl.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Passed QA
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |ASSIGNED
--- Comment #6 from Owen Leonard <oleon...@myacpl.org> ---
I called it "columns_settings.js" because it corresponds to
"columns_settings.inc" and I thought it made sense for them to be the same. I'm
happy to change it. I could also change the name of columns_settings.inc at the
same time.
Anyone have preferences?
I can do the same in the OPAC but I think that can happen on another bug
without holding up this one.
--- Comment #7 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
---
(In reply to Owen Leonard from comment #6)
> I called it "columns_settings.js" because it corresponds to
> "columns_settings.inc" and I thought it made sense for them to be the same.
> I'm happy to change it. I could also change the name of columns_settings.inc
> at the same time.
>
> Anyone have preferences?
Everything should now be "tables_settings".
> I can do the same in the OPAC but I think that can happen on another bug
> without holding up this one.
For consistency I would prefer to keep both in sync. We can do it on a separate
bug report but I will push them together.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
