https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens <n...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119279|0 |1 is obsolete| | Attachment #119280|0 |1 is obsolete| | Attachment #119281|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <n...@bywatersolutions.com> --- Created attachment 119335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119335&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t Rebase - Fix test expectation -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/