https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971
--- Comment #137 from Kyle M Hall <k...@bywatersolutions.com> --- Created attachment 119408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119408&action=edit Bug 23971: (follow-up) Fix tests Following a discussion with Tomás on Slack, this commit implements the following suggestions: - Switch from ->find to ->search in tests. ->find is only ever going to return 0 or 1 rows, which doesn't help us if there is breakage which results in more than 1 row being returned, the test would fail due to ->find not expecting more than 1 row, but we should be testing for it. So switching to ->search returns all matching rows. - Moved tests into their own subtest, they had the potential to pollute surrounding tests - Remove all action logs before each test, this ensures we're only testing the result of the current test Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
