https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118349|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Created attachment 119791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119791&action=edit Bug 20854: (QA follow-up) Improve readability The logout_cas method does too little tasks. In this case, I consider we should not split it into a separate method. As the CAS implementation lacked tests, it made sense to do it like this, so it is testable. But now we have higher-level tests for logout_cas, we can bake the behavior inside of it, and it is testable. Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer...@web.de> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/