https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600
--- Comment #114 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- (In reply to Katrin Fischer from comment #108) > Just wondering about the implications of this as I did some easy rebases > today. Should we ask for new use statements always having the methods used > added with qw? Should there be a coding guideline/QA test? I've tried to explain in the commit message. Basically you need to 1. Use EXPORT_OK instead of EXPORT in modules 2. either use Module qw( method_1 method_2 ); method_1(); or use Module; Module::method_1(); Ideally we should pick one version and stick to that. But there is still a mix of both everywhere in the codebase. We don't really need a guideline because: - We must not add new modules to C4 - The EXPORT_OK should be there now, so you have to write the imports/calls correctly of the execution will explode. (In reply to Marcel de Rooy from comment #109) > [WARN] Prototype mismatch: sub Koha::I18N::LC_MESSAGES: none vs () at > /usr/share/koha/Koha/I18N.pm line 36. > > Locale::Messages exports a sub LC_MESSAGES without prototype. > And after we do 'use POSIX;' with a default import that probably includes > LC_MESSAGES from locale_h ? Last patch fixes that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/