https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
--- Comment #77 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- (In reply to Joonas Kylmälä from comment #76) > - Koha::Biblio::host_items and Koha::Item::columns_to_str need POD and > tests. The additem.pl doesn't load because "The method > Koha::Biblio->host_items is not covered by tests!" so testing cannot be done > currently. It's working for me, looks like you forgot to restart plack. Koha/Biblio.pm:sub host_items { cataloguing/additem.pl:for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) { > - I noticed a lot of bug fixes outside the scope of just removing > Mod/AddItemFromMarc would be nice if those could be splitted to separate > patches that don't even depend on this, also same goes with other patches > having multiple changes in them that are not intertwined. I would be > hesitant to merge these without detailed explanations for every individual > change but not blocking in case other QA team member wants to approve these. I don't really see how I could have split more, the patches have quite isolated changes. I am even suggesting you to review the before/after additem side-by-side. That will be easier to catch potential issues. That being said, I have been working several days on top of those patches and I am pretty confident in them. I am only expected very hard to catch regressions, that are, most of the time, never caught during SO or QA step. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/