https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175
--- Comment #209 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #208) > (In reply to Jonathan Druart from comment #206) > > 1. It needs more work, there is something broken (search does not return > > anything) > > OK, I've done more digging here.. in short, I think we need to make a > distinction between "Analytics" and "Volumes of sets and traced series" akin > to the change bug 7609 made way back. At least for the UseControlNumber > case.. that's what the search results end up empty as I moved the query > without fully understanding it. Actually.. I think this is working as expected.. I just had other issues to resolve. > > 3. I don't think we need the overhead we introduced with the "show all" > > link. We call get_component_part_query from C4::XSLT (for that link) and > > Koha::Biblio (for the list we display). I would suggest retrieving them all > > and have a expand/collapse link if we have "too many" element to display. > > We could then move the get_component_part_query into > > Koha::Biblio->get_marc_components (Koha::Biblio->get_marc_host is doing that > > already). > > I think in theory the reason wasn't to reduce display size but to reduce > search return scope for performance. In reality, I'm not sure this is a real > issue.. need to read the rest of the comments that asked for the reduction > to be introduced.. it all feels very artificial. See comment 90. ES is hard coded to return 100 max unless passed a new max.. there's not option to pass 'all'.. Hense where we're all with passing a search string to get all. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
