https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28927

--- Comment #5 from Fridolin Somers <fridolin.som...@biblibre.com> ---
(In reply to Joonas Kylmälä from comment #4)
> Thanks, I think this change looks reasonable, though some things to fix.
> 
> 1) Could you fix up the commit message, you mention that this fixes a bug
> but don't say which one, also mention in the commit message what the change
> does and use the format "Bug XXXX: Change X thing". I'm guessing you are
> doing this change to simplify (custom) CSS rules?

Oups sorry i did a git mistake.

> 
> 2) It seems to break the OpacHeader / opacheader CSS rule defined in the line
> 
> koha/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss:#opacheader {

Good point i'm on it

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to