http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Chris Nighswonger <cnighswon...@foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13436|0                           |1
        is obsolete|                            |

--- Comment #195 from Chris Nighswonger <cnighswon...@foundations.edu> ---
Created attachment 13526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13526&action=edit
Bug 7167: reindentation & removing dead code

* The if (! defined $ENV{PERL5LIB}... block was wrongly intented
* The 3 lines running update.pl are useless: the update (new mechanism) is run
from admin/updatedatabase.pl script. This part of install.pl is run only when
you have "old style" DB revisions.

Summary:
 * old mechanism = it's run as previously, by reaching the
installer/install.pl?step=3 page, that applies all revisions
 * new mechanism = when you log-in or reach mainpage.pl, you reach
admin/updatedatabase.pl, where you can see what will be run, and run it

Tiny side effect = the check for old mechanism is now done *after*
authentification (thus it's not done on each page call). It means that the user
will have to enter login/password twice :
 * first to log-in to Koha
 * second to run installer/updatedatabase.pl?step=3
As the old mechanism is deprecated, we can expect this will happend only a few
time in the history of a setup, it's not a big deal.

Signed-off-by: Chris Nighswonger <cnighswon...@foundations.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to