https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29134
--- Comment #4 from Nick Clemens <n...@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3) > (In reply to Jonathan Druart from comment #2) > > Created attachment 125453 [details] [review] [review] > > Bug 29134: [ALTERNATIVE patch] Keep filter_by_attribute_value > > > > And build the IN using the existing @matching_borrowernumbers. > > We have a method for that, we should not use raw SQL. > > ~600-700ms with Nick's patch > 22s on master > ~600-700ms with this alternative patch. At 500k patrons with 100k attributes the alternate is a bit slower The query can still be large (caharacter count) with the IN, and requires 2 db calls, one for filter_borrowers_by_attribute, another to search the borrower DV Moving to Objects is nice, but I think pure SQL here makes more sense than mixing the two - I opened bug 29125 to remove all the SQL here -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/