https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142
--- Comment #42 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- while ( my $item = $items->next ) { - $norequests = 0 - if $norequests - && !$item->withdrawn - && !$item->itemlost - && ($item->notforloan < 0 || not $item->notforloan ) - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan - && $item->itemnumber; - $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => $patron } ) unless $allow_onshelf_holds; Could this loop be done smarter now? opac/opac-ISBDdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac/opac-MARCdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac-detail.pl - && !$itemtypes->{$itm->{'itype'}}->{notforloan} Added a follow-up that looks at notforloan but effective is still another story. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/