https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28307
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make BakerTaylorEnabled |Enable BakerTaylorEnabled |preference separate for |content in the staff |staff and OPAC |interface Keywords| |release-notes-needed Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Having a look here - I can' test BakerTaylor content, so having a real close look at the code. As Owen pointed out this was not present before, so I think the small thing here is that the pref description was wrong before, but the big thing is that we add the content to staff! So I took the liberty to adjust the pref description a bit (change back if you hate it) As we rename the pref for the OPAC, I expected a lot more name changes there. Checking with git grep I believe some were missed: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc:[% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( OPACLocalCoverImages || OPACAmazonCoverImages || ( SyndeticsEnabled && SyndeticsCoverImages ) || GoogleJackets || BakerTaylorEnabled || ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) || ( Koha.Preference('OPACCustomCoverImages') AND Koha.Preference('CustomCoverImagesURL') ) ) %] koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt:[% IF ( BakerTaylorEnabled ) %][% IF bt_id %]<a href="https://[% BakerTaylorBookstoreURL |url %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL |url %][% bt_id | uri %]" /></a>[% END %][% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: [% IF BakerTaylorEnabled %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && !BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt: [% IF ( BakerTaylorEnabled && BakerTaylorBookstoreURL ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && !Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt: [% IF ( Koha.Preference('BakerTaylorEnabled') && Koha.Preference('BakerTaylorBookstoreURL') ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt:[% IF ( BakerTaylorEnabled && bt_id ) %]<a href="https://[% BakerTaylorBookstoreURL | uri %][% bt_id | uri %]"><img alt="See Baker & Taylor" src="[% BakerTaylorImageURL | html %][% bt_id | html %]" /></a>[% END %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt: [% IF ( BakerTaylorEnabled ) %] Only seeing this one was changed: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt: [% IF ( OPACBakerTaylorEnabled && bt_id ) %] I think the issue is in the test plan, it should be: Disable staff interface and only enable OPAC. Verify it all still shows correctly. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/