https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- As Marcel already stated, this is really interesting! I am starting with some simple testing and code review - I have not dug into 11175 yes, but I believe it covers a certain type of link, while what has been started here could be useful for a lot of the other link types. 1) Only add cni search part, if CNI is present As the patch stands right now it will always add the AND cni: bit, even if the $w doesn't contain a CNI part. I think it would be a little nicer, if we made the template create the whole query string and account for the missing CNI part. This template could then be easily reused for all 7xx and 8xx linking fields present in the code. 2) Staff and OPAC should be changed We already got a lot of inconistencies here - so we should at least try not to make it worse. Same change should be applied to the OPAC files. Glad to have some discussion! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/