https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440
Martin Renvoize <martin.renvo...@ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize@ptfs-europe
| |.com
--- Comment #23 from Martin Renvoize <martin.renvo...@ptfs-europe.com> ---
Nice work David..
On with the review:
1. You appear to introduce a few new modules, but I'm not seeing some of them
actually used. [List::MoreUtils qw(any), Koha::Plugins::Handler;]
2. With such an extensive tidy up.. I'd probably go ahead and run it through
perltidy as a final patch.. (I did this on the before and after script to make
comparing simpler)
Otherwise, this is generally looking very reasonable to me.
I'm going to run a few more test runs against it and ask our migrations team to
have a play
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
