https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29628
David Nind <da...@davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128220|0 |1
is obsolete| |
--- Comment #4 from David Nind <da...@davidnind.com> ---
Created attachment 128243
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128243&action=edit
Bug 29628: (follow-up) fix for rare edge case
When the number of pending suggestions in the currently selected branch
is equal to the number of pending suggestions across all branches, the
`all_pendingsuggestions` template parameter is equal to 0. This results
in the "Suggestions pending approval:" block not being printed at all.
This follow-up patch fixes that.
Also fixed is the display of pending suggestions in Home > Acquisitions.
Test plan:
1) Apply this patch.
2) Create two Library branches; submit two suggestions in each one.
3) Visit the Home page, and also visit Home > Acquisitions: you should
only see "${BRANCH_CODE}: 2" suggestions pending approval, regardless
of the branch you have selected using the 'Set library' menu option.
4) Delete both suggestions from the 1st branch, and set your library
to be the 1st branch.
5) Visit the same pages: this time "${BRANCH_CODE}: 0 / All libraries: 2"
is displayed.
6) Set your library to be the 2nd branch, and visit the same two pages:
this time "${BRANCH_CODE}: 2" is displayed.
Signed-off-by: David Nind <da...@davidnind.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
