https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29765
David Nind <da...@davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #128887|0 |1
is obsolete| |
--- Comment #4 from David Nind <da...@davidnind.com> ---
Created attachment 128928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128928&action=edit
Bug 29765: Make Koha::Patron->safe_to_delete use Koha::Result::Boolean
This patch makes the safe_to_delete method in Koha::Patron return this
new object type instead of a plain string. This way we have a consistent
way to deal with 'can_*'-like methods return values when feedback is
needed.
To test:
1. Apply this patch
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Patron.t
=> SUCCESS: The adjusted tests pass. Tests cover the boolean context
eval and also the carried messages, that include the same string code
that was returned originally.
3. Sign off :-D
Signed-off-by: David Nind <da...@davidnind.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
