https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
Martin Renvoize <martin.renvo...@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #70 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- (In reply to Joonas Kylmälä from comment #56) Thanks for the review Joonas, it was really helpful! > 1. Some of the patches are missing check if there is any transfer at all > before proceeding to check in_transit status: > > + my $transfer = $item->get_transfer; > + if ( $transfer->in_transit ) { > Great catch, fixed inline in all patches now. > 2. The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation" > needs to come last in the patch series, so just reorder and reattach the > patches. Done > 3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches > that use the output_pref function here. Another good catch, done inline in all patches now. > 4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and > minutes, please bring them back :) Doh, sorted now. > 5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the > in_transit transfers, it used to return all transfers previously, even those > not yet sent (so in queue). Could you double-check on this? I think it is > okay and the previous behaviour was buggy as it says they are IN_TRANSIT > transfers, not queued ones. I agree with your conclusion here. It took a bit of digging first time around to come to that conclusion but I did the change by design here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/