https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #3 from Katrin Fischer <katrin.fisc...@bsz-bw.de> ---
1) Having the descriptions come from the .pl file doesn't sit well with me.
Although I think in these cases a change for translation is probably unlikely.
If something else was to be added, like an explanatory note, we for sure would
need to move it out to the templates. Maybe we could consider moving it anyway
for better coding practice?
2) I think QA would love some unit tests on the change in Order.pm
3) Schema change should have been a separate patch ;)
All those are not being blockers for my sign-off, but:
4) The summary table shows the code instead of the description. The form and
the summary table should match up.
5) The atomic file needs the executable flag to be added (I had done this in a
follow-up, but I think better you do it when fixing 4) )
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
