https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669
--- Comment #19 from Nick Clemens <n...@bywatersolutions.com> --- (In reply to Julian Maurice from comment #17) > I don't like to have a switch for that (I'd prefer Koha to detect > automatically the ES version) but if we have it, I think it makes sense to > have it close to the other ES settings. > For instance, while testing it was easy to switch from one version of ES to > another by (de)commenting a block in $KOHA_CONF > > I don't understand why we would need to update this setting during a Koha > upgrade. ES will not necessarily be upgraded at the same time as Koha. Can > you explain a bit more what would be the benefits of having that setting as > a syspref ? I was thinking of the last time we moved required version of ES https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 I like the syspref because it can provide more control to the user and is more visible and can include notes about the need, like ElasticsearchCrossFields. If a conf switch is preferred we should add something to the about page If it's in the koha-conf - then I think it should be in the elasticsearch stanza: <elasticsearch> <server>es:9200</server> <index_name>koha_kohadev</index_name> <no_type>1</no_type> </elasticsearch> As it will be the standard in the future, i.e. everyone will want no type as ES6 is no longer supported I would rather see the switch the other way: <include_type_name> to mirror the ES setting and their instructions Looking deeper while typing this, we can also take advantage of include_type_name parameter to get us through ES7, patch coming -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/