https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029
Hayley Pelham <hayleypel...@catalyst.net.nz> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleypel...@catalyst.net.n
| |z
--- Comment #24 from Hayley Pelham <hayleypel...@catalyst.net.nz> ---
(In reply to Martin Renvoize from comment #22)
> Comment on attachment 130516 [details] [review]
> Bug 12029: Patrons should be able to delete their patron messages
>
> Review of attachment 130516 [details] [review]:
> -----------------------------------------------------------------
>
> ::: installer/data/mysql/kohastructure.sql
> @@ +3739,4 @@
> > `message` mediumtext COLLATE utf8mb4_unicode_ci NOT NULL COMMENT 'the
> > text of the message',
> > `message_date` timestamp NOT NULL DEFAULT current_timestamp() COMMENT
> > 'the date and time the message was written',
> > `manager_id` int(11) DEFAULT NULL COMMENT 'creator of message',
> > + `patron_read_date` timestamp NULL DEFAULT NULL COMMENT 'date and time
> > the patron dismissed the message',
>
> Final additional note from my own review:
>
> Shouldn't this be a DATETIME rather than a TIMESTAMP field?
As the similar field message_date is also a timestamp I see no need to change
this aspect of the patch at this stage. Please let me know if you have other
reasoning!
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
