http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882
Elliott Davis <elli...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Signed Off
--- Comment #9 from Elliott Davis <elli...@bywatersolutions.com> ---
(In reply to comment #7)
> Hi Elliott,
>
> Some remarks:
>
> 1/ Could you provide a patch with yours modifications and 1 patch for the
> indentation please ? It is not easy at all to read the patch.
>
> 2/ I just have fields on the first tab, the others tabs are empty.
>
I have corrected this issue
> 3/ The title for the cursor_split image is wrong ("move up")
>
I corrected this to say move
> 4/ the following if statement is not graceful:
> if(flag){
> return StrAlert;
> } else {
> return flag;
> }
> It could be replaced with if ( flag ) return StrAlert; return 0;
>
This was added with the tab fix. It appears that the file had tabs in it
before and when I replaced them with spaces I got more diff than I bargained
for.
> Marked as Failed QA.
I don't suppose there is any way to let the changes in whitespace slide. I
think to correct them I'd have to re-write the patch.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
