https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346
--- Comment #51 from Tomás Cohen Arazi <tomasco...@gmail.com> --- Created attachment 134309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134309&action=edit Bug 29346: Refactor loop code into a subroutine The CreateQueue() method deletes the holds queue data, fetches some configuration (branches to use, transport cost matrix) and then loops through a list of biblionumbers, generating the tmp_holdsqueue and hold_fill_targets rows for the specified biblio. This patch simply moves that last bit that is run inside the biblios loop into a separate sub. The update_queue_for_biblio sub is designed so it does the exact same thing it did inside the loop, but also gets added the capability of querying those parameters if not passed, and it also gets a 'delete' parameter so it deletes the biblio-specific holds queue rows before starting to work. This way, it can be reused to write a background job for real-time holds queue update :-D To test: 1. Run: $ kshell k$ prove t/db_dependent/HoldsQueue.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! Behavior is kept! 4. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/