https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
Owen Leonard <oleon...@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135920|0 |1 is obsolete| | Attachment #136041|0 |1 is obsolete| | Attachment #136042|0 |1 is obsolete| | Attachment #136043|0 |1 is obsolete| | Attachment #136044|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleon...@myacpl.org> --- Created attachment 136085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136085&action=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard <oleon...@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/